Skip to content

Conversation

@dhruvmicrosoft
Copy link
Contributor

This pull request includes changes to the ha_db_hana role and its associated tests, focusing on improving the test infrastructure and modifying task names for clarity. The most important changes include adding a new test class for the HANA DB block network, modifying task names in the playbook, and creating mock data scripts for testing purposes.

Test Infrastructure Improvements:

  • tests/roles/ha_db_hana/block_network_test.py: Added a new test class TestBlockNetworkTest to validate the HANA DB block network between primary and secondary nodes. This class sets up a temporary test environment, mocks necessary Python modules and commands, and verifies the execution of the tasks.

Playbook Modifications:

Mock Data Scripts:

Testing

Test Environment

  • OS:
  • SAP Version:
  • Database Type:

@dhruvmicrosoft dhruvmicrosoft requested a review from a team as a code owner March 25, 2025 19:28
@dhruvmicrosoft dhruvmicrosoft requested a review from KimForss March 25, 2025 19:28
devanshjainms
devanshjainms previously approved these changes Mar 25, 2025
@hdamecharla hdamecharla self-requested a review March 26, 2025 10:11
@hdamecharla hdamecharla self-assigned this Mar 26, 2025
hdamecharla
hdamecharla previously approved these changes Mar 26, 2025
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hdamecharla hdamecharla dismissed stale reviews from devanshjainms and themself via ba6d714 March 26, 2025 11:09
@hdamecharla hdamecharla self-requested a review March 26, 2025 11:10
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hdamecharla hdamecharla merged commit 8e105cc into Azure:main Mar 26, 2025
9 checks passed
@hdamecharla hdamecharla deleted the block-network-test branch March 26, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants